Skip to content

New version: libvips.libvips version 8.17.3#308988

Closed
jo-chemla wants to merge 2 commits intomicrosoft:masterfrom
jo-chemla:libvips.libvips-8.17.3-749B6107B9534D26B54E864867A9BE60
Closed

New version: libvips.libvips version 8.17.3#308988
jo-chemla wants to merge 2 commits intomicrosoft:masterfrom
jo-chemla:libvips.libvips-8.17.3-749B6107B9534D26B54E864867A9BE60

Conversation

@jo-chemla
Copy link
Contributor

@jo-chemla jo-chemla commented Nov 1, 2025 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with WinGet Updater 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

wingetbot commented Nov 1, 2025

Validation Pipeline Run WinGetSvc-Validation-100-308988-20251101-1

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 1, 2025
@stephengillie
Copy link
Collaborator

stephengillie commented Nov 1, 2025

Automatic Validation ended with:

Installation failed with exit code -2147467260

Hex Dec Inverted Dec Symbol Description
80004004 -2147467260 2147500036 E_ABORT Operation Aborted

(Automated response - build 113.)

kleisauke
kleisauke reviewed Nov 2, 2025
View reviewed changes
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Installation-Error Error installing application Validation-Executable-Error Needs-Author-Feedback This needs a response from the author. labels Nov 4, 2025
@stephengillie stephengillie added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 4, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Nov 4, 2025
@stephengillie
Copy link
Collaborator

stephengillie commented Nov 4, 2025

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"e53bab0d34622754cdc803b21bff1490a4e171fa"}

(Automated response - build 1139.)

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Nov 4, 2025
@stephengillie
Copy link
Collaborator

stephengillie commented Nov 4, 2025

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"e53bab0d34622754cdc803b21bff1490a4e171fa"}

(Automated response - build 1139.)

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Nov 5, 2025
@stephengillie
Copy link
Collaborator

stephengillie commented Nov 5, 2025

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"e53bab0d34622754cdc803b21bff1490a4e171fa"}

(Automated response - build 1140.)

@stephengillie
Copy link
Collaborator

stephengillie commented Nov 5, 2025

Hi @jo-chemla,

This comment needs to be addressed, before the PR can be merged:

FWIW, version 8.17.2 also needs to be corrected:

winget-pkgs/manifests/l/libvips/libvips/8.17.2/libvips.libvips.installer.yaml

Lines 18 to 20 in e7bab93

- Architecture: x86
InstallerUrl: https://github.com/libvips/build-win64-mxe/releases/download/v8.17.2/vips-dev-w64-all-8.17.2.zip
InstallerSha256: 54F335F12557C6EAF09BF6093F160B56F9761E82091DBA89CD8D3A3BD9AC33E2

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Nov 5, 2025
@jo-chemla @kleisauke
Update manifests/l/libvips/libvips/8.17.3/libvips.libvips.installer.yaml
27509dd 
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
auto-merge was automatically disabled November 5, 2025 09:16

Head branch was pushed to by a user without write access

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 5, 2025
@wingetbot
Copy link
Collaborator

wingetbot commented Nov 5, 2025

Validation Pipeline Run WinGetSvc-Validation-100-308988-20251105-1

@wingetbot
Copy link
Collaborator

wingetbot commented Nov 5, 2025

Validation Pipeline Run WinGetSvc-Validation-100-308988-20251105-2

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest labels Nov 5, 2025
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Nov 5, 2025
@stephengillie
Copy link
Collaborator

stephengillie commented Nov 5, 2025

Automatic Validation ended with:

Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\vips.exe returned exit code: -1073741515

Hex Dec Inverted Dec Symbol Description
C0000135 -1073741515 3221225781 STATUS_DLL_NOT_FOUND Possibly due to a missing dependency. (The most common dependency is Microsoft.VCRedist.2015+.x64 / .x86)

(Automated response - build 1140.)

@kleisauke
Copy link
Contributor

kleisauke commented Dec 11, 2025

Just wondering, was the automatic validation error only on the x86 binaries? Or did it also fail prior to commit 27509dd?

@kleisauke kleisauke mentioned this pull request Dec 11, 2025
Closed
7 tasks
@kleisauke
Copy link
Contributor

kleisauke commented Dec 11, 2025

FWIW, version 8.17.2 also needs to be corrected:

winget-pkgs/manifests/l/libvips/libvips/8.17.2/libvips.libvips.installer.yaml

Lines 18 to 20 in e7bab93

- Architecture: x86
InstallerUrl: https://github.com/libvips/build-win64-mxe/releases/download/v8.17.2/vips-dev-w64-all-8.17.2.zip
InstallerSha256: 54F335F12557C6EAF09BF6093F160B56F9761E82091DBA89CD8D3A3BD9AC33E2

I just opened PR #322202 for this.

kleisauke
kleisauke reviewed Dec 11, 2025
View reviewed changes
manifests/l/libvips/libvips/8.17.3/libvips.libvips.locale.en-US.yaml
Author: libvips
PackageName: libvips
PackageUrl: https://github.com/libvips/build-win64-mxe
License: LGPL-2.1
Copy link
Contributor

@kleisauke kleisauke Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
License: LGPL-2.1
License: LGPL-2.1-or-later

(I also opened PR #322204 and #322205 for this)

@kleisauke kleisauke mentioned this pull request Dec 15, 2025
Merged
7 tasks
@jo-chemla jo-chemla closed this Dec 16, 2025
auto-merge was automatically disabled December 16, 2025 11:23

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] left review comments

@stephengillie stephengillie stephengillie left review comments

+1 more reviewer

@kleisauke kleisauke kleisauke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@stephengillie stephengillie

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Manifest Validation-Executable-Error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jo-chemla @wingetbot @stephengillie @kleisauke